New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: support multiline /*eslint-env*/ directives (fixes #14652) #14660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
bug
ESLint is working incorrectly
core
Relates to ESLint's core APIs and features
accepted
There is consensus among the team that this change meets the criteria for inclusion
labels
Jun 3, 2021
mdjermanovic
added
evaluating
The team will evaluate this issue to decide whether it meets the criteria for inclusion
and removed
accepted
There is consensus among the team that this change meets the criteria for inclusion
labels
Jun 3, 2021
mdjermanovic
reviewed
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be tagged as Update:
, as it could enable new globals in an existing code.
For example, this will be a new error:
/* eslint-env browser
*/
/* eslint no-shadow: ["error", { "builtinGlobals": true }] */
window => {}
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
aladdin-add
changed the title
Fix: linter ignores multiline /*eslint-env*/ directives (fixes #14652)
Update: linter ignores multiline /*eslint-env*/ directives (fixes #14652)
Jun 3, 2021
aladdin-add
changed the title
Update: linter ignores multiline /*eslint-env*/ directives (fixes #14652)
Update: linter ignores multiline /*eslint-env*/ directives(fixes #14652)
Jun 3, 2021
aladdin-add
changed the title
Update: linter ignores multiline /*eslint-env*/ directives(fixes #14652)
Update: multiline /*eslint-env*/ directives (fixes #14652)
Jun 3, 2021
aladdin-add
changed the title
Update: multiline /*eslint-env*/ directives (fixes #14652)
Update: support multiline /*eslint-env*/ directives (fixes #14652)
Jun 3, 2021
mdjermanovic
added
accepted
There is consensus among the team that this change meets the criteria for inclusion
and removed
evaluating
The team will evaluate this issue to decide whether it meets the criteria for inclusion
labels
Jun 4, 2021
mdjermanovic
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
eslint-github-bot
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Dec 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
core
Relates to ESLint's core APIs and features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
update the regexp to allow linebreaks.
Is there anything you'd like reviewers to focus on?
not really.